Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change username button layout #783 #795

Merged
merged 13 commits into from
Jun 16, 2022

Conversation

hocinehacherouf
Copy link
Contributor

@hocinehacherouf hocinehacherouf commented Jun 13, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Feature

Move appbar content to a separated component
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #795 (a9d7436) into main (b6ce93f) will increase coverage by 0.09%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   76.26%   76.36%   +0.09%     
==========================================
  Files         140      141       +1     
  Lines        4749     4756       +7     
==========================================
+ Hits         3622     3632      +10     
+ Misses       1127     1124       -3     
Impacted Files Coverage Δ
.../AzureIoTHub.Portal/Client/Shared/MainLayout.razor 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Client/Shared/Appbar.razor 44.44% <44.44%> (ø)
...zureIoTHub.Portal/Client/Services/LayoutService.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ce93f...a9d7436. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the feature/783_change_username_button_layout branch from 1048f4c to db41eb6 Compare June 15, 2022 07:19
@hocinehacherouf hocinehacherouf marked this pull request as ready for review June 15, 2022 17:41
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner June 15, 2022 17:41
@kbeaugrand
Copy link
Member

image

@kbeaugrand kbeaugrand merged commit 98ffaf4 into main Jun 16, 2022
@kbeaugrand kbeaugrand deleted the feature/783_change_username_button_layout branch June 16, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants