-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework problem details exceptions on edge devices views #809
Merged
kbeaugrand
merged 19 commits into
main
from
feature/790_rework_pb_details_on_edge_devices_views
Jun 17, 2022
Merged
Rework problem details exceptions on edge devices views #809
kbeaugrand
merged 19 commits into
main
from
feature/790_rework_pb_details_on_edge_devices_views
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ut GetEdgeDeviceLogsMustThrowProblemDetailsExceptionWhenErrorOccurs
Codecov Report
@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 76.36% 78.47% +2.11%
==========================================
Files 141 141
Lines 4756 4781 +25
==========================================
+ Hits 3632 3752 +120
+ Misses 1124 1029 -95
Continue to review full report at Codecov.
|
Add unit tests on ConnectionStringDialog for edge
kbeaugrand
approved these changes
Jun 17, 2022
kbeaugrand
deleted the
feature/790_rework_pb_details_on_edge_devices_views
branch
June 17, 2022 06:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?