Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework problem details exceptions on edge devices views #809

Merged
merged 19 commits into from
Jun 17, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Feature

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #809 (1c74799) into main (e6ac327) will increase coverage by 2.11%.
The diff coverage is 82.52%.

@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   76.36%   78.47%   +2.11%     
==========================================
  Files         141      141              
  Lines        4756     4781      +25     
==========================================
+ Hits         3632     3752     +120     
+ Misses       1124     1029      -95     
Impacted Files Coverage Δ
...nt/Pages/Edge_Devices/CreateEdgeDeviceDialog.razor 25.00% <10.00%> (+25.00%) ⬆️
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 66.66% <82.60%> (+66.66%) ⬆️
...ient/Pages/Edge_Devices/EdgeDeviceDetailPage.razor 91.34% <88.63%> (+1.45%) ⬆️
...nt/Pages/Edge_Devices/ConnectionStringDialog.razor 85.71% <100.00%> (+85.71%) ⬆️
...e_Devices/EdgeDeviceDeleteConfirmationDialog.razor 100.00% <100.00%> (+100.00%) ⬆️
...l/Client/Pages/Edge_Devices/ModuleLogsDialog.razor 100.00% <100.00%> (+28.57%) ⬆️
....Portal/Client/Services/EdgeDeviceClientService.cs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ac327...1c74799. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review June 16, 2022 20:27
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner June 16, 2022 20:27
@kbeaugrand kbeaugrand enabled auto-merge (squash) June 17, 2022 04:58
@kbeaugrand kbeaugrand merged commit a9ae18e into main Jun 17, 2022
@kbeaugrand kbeaugrand deleted the feature/790_rework_pb_details_on_edge_devices_views branch June 17, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants