Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #579 - Add default values to documentation in API models #814

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Jun 16, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner June 16, 2022 19:05
@kbeaugrand kbeaugrand force-pushed the fix/579-add-default-values-in-documentation branch from d8584ce to 91074f3 Compare June 16, 2022 20:03
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #814 (91074f3) into main (8331cb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files         141      141           
  Lines        4756     4756           
=======================================
  Hits         3632     3632           
  Misses       1124     1124           
Impacted Files Coverage Δ
...reIoTHub.Portal/Shared/Models/v1.0/DeviceConfig.cs 100.00% <ø> (ø)
...IoTHub.Portal/Shared/Models/v1.0/DeviceProperty.cs 100.00% <ø> (ø)
...AzureIoTHub.Portal/Shared/Models/v1.0/DeviceTag.cs 100.00% <ø> (ø)
...ortal/Shared/Models/v1.0/LoRaWAN/LoRaDeviceBase.cs 96.00% <ø> (ø)
.../Shared/Models/v1.0/LoRaWAN/LoRaDeviceModelBase.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8331cb9...91074f3. Read the comment docs.

@kbeaugrand kbeaugrand enabled auto-merge (squash) June 16, 2022 20:26
@kbeaugrand kbeaugrand merged commit e6ac327 into main Jun 16, 2022
@kbeaugrand kbeaugrand deleted the fix/579-add-default-values-in-documentation branch June 16, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story: As a developer, I Want to provide default values to my API's payloads
2 participants