Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/finish rework pb details frontend #837

Merged
merged 16 commits into from
Jun 21, 2022
Merged

Feature/finish rework pb details frontend #837

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2b736e5
Rework pb details on DeleteConcentratorPage #833
hocinehacherouf Jun 20, 2022
5064819
Rework pb details on CreateConcentratorPage #833
hocinehacherouf Jun 20, 2022
ed4134a
Rework pb details on ConcentratorDetailPage #833
hocinehacherouf Jun 20, 2022
4752aec
Rework pb details on ConcentratorListPage #833
hocinehacherouf Jun 20, 2022
e8a3cd5
Add + update unit tests on ConcentratorDetailPageTests #833
hocinehacherouf Jun 20, 2022
9d9fcc4
Add missing DialogService.Close() #833
hocinehacherouf Jun 20, 2022
8e36864
Add unit tests on CreateConcentratorPageTest #833
hocinehacherouf Jun 20, 2022
6cbd134
Add unit tests on DeleteConcentratorPageTests #833
hocinehacherouf Jun 20, 2022
6f2f3ba
Add unit tests on ConcentratorListPageTests #833
hocinehacherouf Jun 20, 2022
77849cd
Fix unit tests on ConcentratorDetailPageTests
hocinehacherouf Jun 20, 2022
4966eab
Rework pb details on DeviceConfigurationListPage + Add unit tests #789
hocinehacherouf Jun 20, 2022
5c5e2d0
Rework pb details on CreateDeviceConfigurationsPage + Add unit tests…
hocinehacherouf Jun 20, 2022
1c7a3a9
Rework pb details on DeviceConfigurationDetailPage + Add unit tests …
hocinehacherouf Jun 20, 2022
0ec823b
Fix unit test EdgeDeviceListPageShouldResetOnClickOnReset #827
hocinehacherouf Jun 20, 2022
61036b1
Rework pb details on DeleteDeviceConfiguration + Add unit tests #789
hocinehacherouf Jun 20, 2022
a20d522
Add unit test tests #833 #789
hocinehacherouf Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
326 changes: 57 additions & 269 deletions ...ortal.Server.Tests.Unit/Pages/DeviceConfigurations/CreateDeviceConfigurationsPageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,66 +4,50 @@
namespace AzureIoTHub.Portal.Server.Tests.Unit.Pages
{
using System;
using System.Collections.Generic;
using System.Net.Http;
using System.Net.Http.Json;
using System.Threading.Tasks;
using AngleSharp.Dom;
using Bunit;
using Client.Exceptions;
using Client.Models;
using Client.Pages.DeviceConfigurations;
using FluentAssertions;
using Helpers;
using Microsoft.AspNetCore.Components;
using Microsoft.Extensions.DependencyInjection;
using Models;
using Models.v10;
using Moq;
using MudBlazor;
using MudBlazor.Interop;
using MudBlazor.Services;
using NUnit.Framework;
using Portal.Shared.Models.v10;
using RichardSzalay.MockHttp;

[TestFixture]
public class CreateDeviceConfigurationsPageTests : IDisposable
public class CreateDeviceConfigurationsPageTests : TestContextWrapper, IDisposable
{
#pragma warning disable CA2213 // Disposable fields should be disposed
private Bunit.TestContext testContext;
private MockHttpMessageHandler mockHttpClient;
#pragma warning restore CA2213 // Disposable fields should be disposed

private MockRepository mockRepository;
private Mock<IDialogService> mockDialogService;

[SetUp]
public void SetUp()
{
this.testContext = new Bunit.TestContext();
TestContext = new Bunit.TestContext();

this.mockRepository = new MockRepository(MockBehavior.Strict);
this.mockHttpClient = this.testContext.Services.AddMockHttpClient();
this.mockHttpClient = TestContext.Services.AddMockHttpClient();
this.mockDialogService = this.mockRepository.Create<IDialogService>();

_ = this.testContext.Services.AddSingleton(this.mockDialogService.Object);
_ = this.testContext.Services.AddMudServices();
_ = TestContext.Services.AddSingleton(this.mockDialogService.Object);
_ = TestContext.Services.AddMudServices();

_ = this.testContext.JSInterop.SetupVoid("mudKeyInterceptor.connect", _ => true);
_ = this.testContext.JSInterop.SetupVoid("mudPopover.connect", _ => true);
_ = this.testContext.JSInterop.Setup<BoundingClientRect>("mudElementRef.getBoundingClientRect", _ => true);
}
TestContext.JSInterop.Mode = JSRuntimeMode.Loose;

private IRenderedComponent<TComponent> RenderComponent<TComponent>(params ComponentParameter[] parameters)
where TComponent : IComponent
{
return this.testContext.RenderComponent<TComponent>(parameters);
this.mockHttpClient.AutoFlush = true;
}

[Test]
public void DeviceConfigurationDetailPageShouldRenderCorrectly()
{
// Arrange
using var deviceResponseMock = new HttpResponseMessage();

var modelId = Guid.NewGuid().ToString();

_ = this.mockHttpClient
Expand All @@ -82,7 +66,47 @@ public void DeviceConfigurationDetailPageShouldRenderCorrectly()
var cut = RenderComponent<CreateDeviceConfigurationsPage>();

// Assert
cut.WaitForState(() => !cut.Instance.IsLoading);
cut.WaitForAssertion(() => cut.Instance.IsLoading.Should().BeFalse());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingRequest());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingExpectation());
}

[Test]
public void DeviceConfigurationDetailPageShouldProcessProblemDetailsExceptionWhenIssueOccursOnLoadingModels()
{
// Arrange
_ = this.mockHttpClient
.When(HttpMethod.Get, "/api/models")
.Throw(new ProblemDetailsException(new ProblemDetailsWithExceptionDetails()));

// Act
var cut = RenderComponent<CreateDeviceConfigurationsPage>();

// Assert
cut.WaitForAssertion(() => cut.Instance.IsLoading.Should().BeFalse());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingRequest());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingExpectation());
}

[Test]
public void DeviceConfigurationDetailPageShouldProcessProblemDetailsExceptionWhenIssueOccursOnLoadingTags()
{
// Arrange
_ = this.mockHttpClient
.When(HttpMethod.Get, "/api/models")
.RespondJson(Array.Empty<DeviceModel>());

_ = this.mockHttpClient
.When(HttpMethod.Get, "/api/settings/device-tags")
.Throw(new ProblemDetailsException(new ProblemDetailsWithExceptionDetails()));

// Act
var cut = RenderComponent<CreateDeviceConfigurationsPage>();

// Assert
cut.WaitForAssertion(() => cut.Instance.IsLoading.Should().BeFalse());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingRequest());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingExpectation());
}

[Test]
Expand Down Expand Up @@ -125,7 +149,9 @@ public void WhenClickToDeleteTagShouldRemoveTheSelectedTag()
deleteTagButton.Click();

// Assert
Assert.AreEqual(1, cut.Instance.Configuration.Tags.Count);
_ = cut.Instance.Configuration.Tags.Count.Should().Be(1);
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingRequest());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingExpectation());
}

[Test]
Expand Down Expand Up @@ -168,249 +194,11 @@ public void WhenClickToAddTagShouldAddTheSelectedTag()

// Assert
_ = cut.WaitForElement("#tag-tag1");
Assert.AreEqual(1, cut.Instance.Configuration.Tags.Count);
_ = cut.Instance.Configuration.Tags.Count.Should().Be(1);
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingRequest());
cut.WaitForAssertion(() => this.mockHttpClient.VerifyNoOutstandingExpectation());
}

//[Test]
//public void WhenClickToDeletePropertyShouldRemoveTheSelectedProperty()
//{
// // Arrange
// using var deviceResponseMock = new HttpResponseMessage();

// var modelId = Guid.NewGuid().ToString();

// var model = new DeviceModel
// {
// ModelId = modelId,
// Name = Guid.NewGuid().ToString()
// };

// _ = this.mockHttpClient
// .When(HttpMethod.Get, "/api/models")
// .RespondJson(new []
// {
// model
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, $"/api/models/{modelId}/properties")
// .RespondJson(new DeviceProperty[]
// {
// new() {
// Name = "prop1",
// PropertyType = DevicePropertyType.Boolean
// },
// new() {
// Name = "prop2",
// PropertyType = DevicePropertyType.Double
// },
// new() {
// Name = "prop3",
// PropertyType = DevicePropertyType.Float
// },
// new() {
// Name = "prop4",
// PropertyType = DevicePropertyType.Integer
// },
// new() {
// Name = "prop5",
// PropertyType = DevicePropertyType.Long
// },
// new() {
// Name = "prop6",
// PropertyType = DevicePropertyType.String
// }
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, "/api/settings/device-tags")
// .RespondJson(Array.Empty<DeviceTag>());

// var cut = RenderComponent<CreateDeviceConfigurationsPage>();
// cut.WaitForState(() => !cut.Instance.IsLoading);
// cut.WaitForElement("#selectDeviceModel").Change(model);

// cut.Instance.SelectedTag = "prop1";
// cut.Render();
// cut.WaitForElement("#addPropertyButton").Click();

// cut.Instance.SelectedTag = "prop2";
// cut.Render();
// cut.WaitForElement("#addPropertyButton").Click();

// // Act
// cut.WaitForElement("#property-prop2 #deletePropertyButton").Click();

// // Assert
// Assert.AreEqual(1, cut.Instance.Configuration.Properties.Count);
//}

//[Test]
//public async Task WhenClickToAddPropertyShouldAddTheSelectedProperty()
//{
// // Arrange
// using var deviceResponseMock = new HttpResponseMessage();

// var modelId = Guid.NewGuid().ToString();

// var model = new DeviceModel
// {
// ModelId = modelId,
// Name = Guid.NewGuid().ToString()
// };

// _ = this.mockHttpClient
// .When(HttpMethod.Get, "/api/models")
// .RespondJson(new[]
// {
// model
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, $"/api/models/{modelId}/properties")
// .RespondJson(new DeviceProperty[]
// {
// new() {
// Name = "prop1",
// PropertyType = DevicePropertyType.Boolean,
// IsWritable = true
// },
// new() {
// Name = "prop2",
// PropertyType = DevicePropertyType.Double,
// IsWritable = true
// },
// new() {
// Name = "prop3",
// PropertyType = DevicePropertyType.Float,
// IsWritable = true
// },
// new() {
// Name = "prop4",
// PropertyType = DevicePropertyType.Integer,
// IsWritable = true
// },
// new() {
// Name = "prop5",
// PropertyType = DevicePropertyType.Long,
// IsWritable = true
// },
// new() {
// Name = "prop6",
// PropertyType = DevicePropertyType.String,
// IsWritable = true
// }
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, "/api/settings/device-tags")
// .RespondJson(Array.Empty<DeviceTag>());

// var cut = RenderComponent<CreateDeviceConfigurationsPage>();
// cut.WaitForState(() => !cut.Instance.IsLoading);
// await cut.Instance.SelectModel(model);
// cut.Render();

// // Act
// cut.Instance.SelectedTag = "prop1";
// cut.Find("#addPropertyButton").Click();

// // Assert
// _ = cut.WaitForElement("#property-prop1");
// Assert.AreEqual(1, cut.Instance.Configuration.Properties.Count);
//}

//[Test]
//public void WhenClickToSaveShouldSendPutToTheEndpoint()
//{
// // Arrange
// using var deviceResponseMock = new HttpResponseMessage();

// var configurationId = Guid.NewGuid().ToString();
// var modelId = Guid.NewGuid().ToString();

// _ = this.mockHttpClient
// .When(HttpMethod.Get, $"/api/device-configurations/{configurationId}")
// .RespondJson(new DeviceConfig
// {
// Priority = 100,
// ConfigurationId = "test",
// ModelId = modelId,
// Tags = new Dictionary<string, string>()
// {
// { "tag0", "value1" }
// },
// Properties = new Dictionary<string, string>()
// {
// { "prop1", "val1" },
// { "prop2", "val2" }
// }
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, $"/api/device-configurations/{configurationId}/metrics")
// .RespondJson(new ConfigurationMetrics());

// _ = this.mockHttpClient
// .When(HttpMethod.Get, $"/api/models/{modelId}/properties")
// .RespondJson(new DeviceProperty[]
// {
// new() {
// Name = "prop1",
// PropertyType = DevicePropertyType.Boolean
// },
// new() {
// Name = "prop2",
// PropertyType = DevicePropertyType.Double
// },
// new() {
// Name = "prop3",
// PropertyType = DevicePropertyType.Float
// },
// new() {
// Name = "prop4",
// PropertyType = DevicePropertyType.Integer
// },
// new() {
// Name = "prop5",
// PropertyType = DevicePropertyType.Long
// },
// new() {
// Name = "prop6",
// PropertyType = DevicePropertyType.String
// }
// });

// _ = this.mockHttpClient
// .When(HttpMethod.Get, "/api/settings/device-tags")
// .RespondJson(new DeviceTag[]
// {
// new () { Name = "tag0" },
// new () { Name = "tag1" }
// });

// var cut = RenderComponent<DeviceConfigurationDetailPage>(ComponentParameter.CreateParameter("ConfigId", configurationId));
// cut.WaitForState(() => !cut.Instance.IsLoading);

// _ = this.mockHttpClient.When(HttpMethod.Put, $"/api/device-configurations/{configurationId}")
// .RespondText(string.Empty)
// .With(m =>
// {
// Assert.IsAssignableFrom<JsonContent>(m.Content);
// var jsonContent = m.Content as JsonContent;

// Assert.IsAssignableFrom<DeviceConfig>(jsonContent.Value);
// Assert.AreEqual(cut.Instance.Configuration, jsonContent.Value);

// return true;
// });

// // Act
// cut.WaitForElement("#saveButton").Click();

// // Assert
//}

public void Dispose()
{
Dispose(true);
Expand Down
Loading