Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make row clickable on device list page #841

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Jun 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #841 (95ed46b) into main (3c7f02c) will increase coverage by 0.06%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   82.14%   82.20%   +0.06%     
==========================================
  Files         142      142              
  Lines        4934     4952      +18     
==========================================
+ Hits         4053     4071      +18     
  Misses        881      881              
Impacted Files Coverage Δ
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 68.18% <90.90%> (+1.51%) ⬆️
...b.Portal/Client/Pages/Configurations/Configs.razor 100.00% <100.00%> (ø)
...ceConfigurations/DeviceConfigurationListPage.razor 91.17% <100.00%> (+0.85%) ⬆️
...lient/Pages/DeviceModels/DeviceModelListPage.razor 95.55% <100.00%> (+0.31%) ⬆️
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 69.07% <100.00%> (+0.98%) ⬆️
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 59.64% <100.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7f02c...95ed46b. Read the comment docs.

@kbeaugrand kbeaugrand marked this pull request as ready for review June 22, 2022 13:59
@kbeaugrand kbeaugrand requested a review from a team as a code owner June 22, 2022 13:59
@kbeaugrand kbeaugrand merged commit 79daf28 into main Jun 22, 2022
@kbeaugrand kbeaugrand deleted the feature/785-list-should-be-clickable-on-whole-line branch June 22, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Make elements clickable in the whole line
2 participants