Avoid usage of Thread.Sleep : Devices #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audserraCGI
force-pushed
the
818_avoid_usage_of_thread_sleep_on_device_pages
branch
from
36569a9 to
c7fb1d4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _ = this.mockDialogService.Setup(c => c.Close(It.Is<DialogReference>(x => x == mockDialogReference))); | ||
|
|
||
| _ = this.mockSnackbarService.Setup(c => c.Add("One or more validation errors occurred", Severity.Error, null)).Returns((Snackbar)null); | ||
| _ = this.mockSnackbarService.Setup(c => c.Add(It.IsAny<string>(), Severity.Error, null)).Returns((Snackbar)null); |
Check warning
Code scanning / CodeQL
Useless upcast
audserraCGI
force-pushed
the
818_avoid_usage_of_thread_sleep_on_device_pages
branch
from
f485a3e to
ada1d7c
Compare
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 82.93% 83.19% +0.25%
==========================================
Files 149 153 +4
Lines 5234 5277 +43
==========================================
+ Hits 4341 4390 +49
+ Misses 893 887 -6
Continue to review full report at Codecov.
|
kbeaugrand
approved these changes
Jun 24, 2022
kbeaugrand
force-pushed
the
818_avoid_usage_of_thread_sleep_on_device_pages
branch
from
d909e31 to
ab7ab95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?