Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #827 - Fix Tests in CI #846

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Jun 23, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the feature/785-list-should-be-clickable-on-whole-line branch from f7e2c6d to c9d6c5c Compare June 23, 2022 07:28
@kbeaugrand kbeaugrand force-pushed the feature/785-list-should-be-clickable-on-whole-line branch from c9d6c5c to 9230a7c Compare June 23, 2022 07:30
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #846 (9230a7c) into main (3c7f02c) will increase coverage by 0.87%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   82.14%   83.02%   +0.87%     
==========================================
  Files         142      149       +7     
  Lines        4934     5225     +291     
==========================================
+ Hits         4053     4338     +285     
- Misses        881      887       +6     
Impacted Files Coverage Δ
src/AzureIoTHub.Portal/Server/ConfigHandler.cs 0.00% <ø> (ø)
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 68.18% <90.90%> (+1.51%) ⬆️
...rver/Services/ConcentratorMetricExporterService.cs 94.11% <94.11%> (ø)
...tal/Server/Services/DeviceMetricExporterService.cs 94.11% <94.11%> (ø)
...Server/Services/EdgeDeviceMetricExporterService.cs 94.73% <94.73%> (ø)
...Server/Services/ConcentratorMetricLoaderService.cs 97.61% <97.61%> (ø)
...ortal/Server/Services/DeviceMetricLoaderService.cs 97.61% <97.61%> (ø)
...l/Server/Services/EdgeDeviceMetricLoaderService.cs 98.18% <98.18%> (ø)
...b.Portal/Client/Pages/Configurations/Configs.razor 100.00% <100.00%> (ø)
...ceConfigurations/DeviceConfigurationListPage.razor 91.17% <100.00%> (+0.85%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115f0f4...9230a7c. Read the comment docs.

@kbeaugrand kbeaugrand marked this pull request as ready for review June 23, 2022 07:38
@kbeaugrand kbeaugrand requested a review from a team as a code owner June 23, 2022 07:38
@kbeaugrand kbeaugrand merged commit 22f3a13 into main Jun 23, 2022
@kbeaugrand kbeaugrand deleted the feature/785-list-should-be-clickable-on-whole-line branch June 23, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants