Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing using clause on Disposable Instances for unit tests #851

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

kbeaugrand
Copy link
Member

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the fix/missing-usings-for-disposables branch from 8fb5e4e to e53f166 Compare June 23, 2022 11:05
@kbeaugrand kbeaugrand marked this pull request as ready for review June 23, 2022 11:05
@kbeaugrand kbeaugrand requested a review from a team as a code owner June 23, 2022 11:05
@kbeaugrand kbeaugrand enabled auto-merge (squash) June 23, 2022 11:05
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #851 (8fb5e4e) into main (22f3a13) will decrease coverage by 0.08%.
The diff coverage is 68.42%.

❗ Current head 8fb5e4e differs from pull request most recent head e53f166. Consider uploading reports for the commit e53f166 to get more accurate results

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   83.02%   82.93%   -0.09%     
==========================================
  Files         149      149              
  Lines        5225     5234       +9     
==========================================
+ Hits         4338     4341       +3     
- Misses        887      893       +6     
Impacted Files Coverage Δ
...b.Portal/Client/Pages/Configurations/Configs.razor 96.96% <66.66%> (-3.04%) ⬇️
...ceConfigurations/DeviceConfigurationListPage.razor 88.88% <66.66%> (-2.29%) ⬇️
...lient/Pages/DeviceModels/DeviceModelListPage.razor 93.61% <66.66%> (-1.94%) ⬇️
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 67.16% <66.66%> (-1.02%) ⬇️
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 58.62% <66.66%> (-1.03%) ⬇️
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 68.36% <75.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea8ec7...e53f166. Read the comment docs.

@kbeaugrand kbeaugrand disabled auto-merge June 23, 2022 11:38
@kbeaugrand kbeaugrand merged commit f7f7328 into main Jun 23, 2022
@kbeaugrand kbeaugrand deleted the fix/missing-usings-for-disposables branch June 23, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant