Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard with metrics add main page #856

Merged
merged 20 commits into from
Jun 24, 2022
Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #856 (4d11305) into main (affd724) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   82.93%   83.19%   +0.25%     
==========================================
  Files         149      153       +4     
  Lines        5234     5277      +43     
==========================================
+ Hits         4341     4390      +49     
+ Misses        893      887       -6     
Impacted Files Coverage Δ
...lient/Pages/Dashboard/DashboardMetricCounter.razor 100.00% <100.00%> (ø)
...rtal/Client/Pages/Dashboard/DashboardMetrics.razor 100.00% <100.00%> (ø)
...b.Portal/Client/Services/DashboardLayoutService.cs 100.00% <100.00%> (ø)
...l/Client/Services/DashboardMetricsClientService.cs 100.00% <100.00%> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 94.44% <100.00%> (+16.66%) ⬆️
...tal/Server/Controllers/v1.0/DashboardController.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b411b5...4d11305. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review June 23, 2022 21:17
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner June 23, 2022 21:17
@kbeaugrand kbeaugrand merged commit 92f8e34 into main Jun 24, 2022
@kbeaugrand kbeaugrand deleted the feature/781_darshboard branch June 24, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants