Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change menu to add Feature Edge Device models #877

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Change menu to add Feature Edge Device models #877

merged 8 commits into from
Jun 27, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Jun 27, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #877 (a996ed8) into main (3292880) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         153      153           
  Lines        5277     5277           
=======================================
  Hits         4390     4390           
  Misses        887      887
Impacted Files Coverage Δ
....Portal/Client/Pages/EdgeModels/ConfigDetail.razor 60.86% <ø> (ø)
...oTHub.Portal/Client/Pages/EdgeModels/Configs.razor 96.96% <ø> (ø)
....Portal/Client/Pages/EdgeModels/ModuleDetail.razor 0.00% <ø> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 94.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3292880...a996ed8. Read the comment docs.

@hocinehacherouf hocinehacherouf force-pushed the issue#876_rename_menu/page_title_to_Edge_Models branch 3 times, most recently from f61b853 to 13b443e Compare June 27, 2022 14:31
Sben65 and others added 4 commits June 27, 2022 16:48
@Sben65
comment unit test
a38830f
@Sben65
comment SaveShouldProcessProblemDetailsExceptionWhenIssueOccursOnCrea…
1ecc8a9 
…tingDevice
@Sben65
fix code scanning
69be08d
@hocinehacherouf
Fix CreateDeviceUnitTests
a996ed8 
Fix unit test ClickOnSaveShouldPostDeviceDetailsAsync


Remove commented code


Fix unit test ClickOnSaveShouldPostDeviceDetailsAsync


Fix unit test ClickOnSaveShouldPostDeviceDetailsAsync
@hocinehacherouf hocinehacherouf force-pushed the issue#876_rename_menu/page_title_to_Edge_Models branch from 5d02bcb to a996ed8 Compare June 27, 2022 16:54
@Sben65 Sben65 marked this pull request as ready for review June 27, 2022 17:54
@Sben65 Sben65 requested a review from a team as a code owner June 27, 2022 17:54
@kbeaugrand kbeaugrand changed the title task fix #876 Change menu to add Feature Edge Device models Jun 27, 2022
@kbeaugrand kbeaugrand merged commit 3379493 into main Jun 27, 2022
@kbeaugrand kbeaugrand deleted the issue#876_rename_menu/page_title_to_Edge_Models branch June 27, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sben65 @kbeaugrand @hocinehacherouf