Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/868 blazor base unit test wrapper #882

Merged
merged 38 commits into from
Jun 29, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Update DeleteDeviceConfigurationTests to implement BlazorUnitTest #868
Update CreateDevicePageTests to implement BlazorUnitTest #868

public BoundingClientRect GetSizeInfo(ElementReference reference)
{
return !this.cachedValues.ContainsKey(reference) ? null : this.cachedValues[reference];

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey

Inefficient use of 'ContainsKey' and [indexer](1).
@hocinehacherouf hocinehacherouf force-pushed the feature/868_blazor_base_unit_test_wrapper branch from e38d7a0 to 815de5a Compare June 28, 2022 19:50
Fix ut ConnectionStringDialogMustBeCancelledOnClickOnCancel


Fix ut ConnectionStringDialogMustBeCancelledOnClickOnCancel
@hocinehacherouf hocinehacherouf force-pushed the feature/868_blazor_base_unit_test_wrapper branch from 815de5a to 0259af6 Compare June 28, 2022 19:59
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #882 (50a15a5) into main (cfb1fae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         153      153           
  Lines        5277     5277           
=======================================
  Hits         4390     4390           
  Misses        887      887           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb1fae...50a15a5. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review June 28, 2022 20:31
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner June 28, 2022 20:31
@hocinehacherouf hocinehacherouf merged commit b4ce5d9 into main Jun 29, 2022
@hocinehacherouf hocinehacherouf deleted the feature/868_blazor_base_unit_test_wrapper branch June 29, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants