Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/750 auto update copyright year #889

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #889 (afda467) into main (0a4e046) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         153      154    +1     
  Lines        5280     5282    +2     
=======================================
+ Hits         4393     4395    +2     
  Misses        887      887           
Impacted Files Coverage Δ
.../AzureIoTHub.Portal/Client/Shared/MainLayout.razor 96.00% <ø> (-0.16%) ⬇️
...zureIoTHub.Portal/Client/Shared/PortalFooter.razor 100.00% <100.00%> (ø)
...rtal/Server/Controllers/v1.0/SettingsController.cs 100.00% <100.00%> (ø)
...IoTHub.Portal/Shared/Models/v1.0/PortalSettings.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4e046...afda467. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review June 29, 2022 17:42
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner June 29, 2022 17:42
var result = objectResult?.Value as PortalSettings;

// Assert
_ = result.Should().NotBeNull();

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [result](1) may be null here because of [this](2) assignment.
@hocinehacherouf hocinehacherouf merged commit 34bbc42 into main Jun 29, 2022
@hocinehacherouf hocinehacherouf deleted the feature/750_auto_update_copyright_year branch June 29, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants