Fix #843 - Issue when creating a new device if the DeviceID already exists #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeaugrand
changed the title
kbeaugrand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 82.98% 83.00% +0.01%
==========================================
Files 154 154
Lines 5296 5300 +4
==========================================
+ Hits 4395 4399 +4
Misses 901 901
Continue to review full report at Codecov.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -191,6 +191,9 @@ | |||
|
|
|||
| Twin twin = null; | |||
|
|
|||
| _ = this.mockDeviceService.Setup(c => c.GetDevice(It.IsAny<string>())) | |||
| .ReturnsAsync((Device)null); | |||
Check warning
Code scanning / CodeQL
Useless upcast
| @@ -396,6 +396,9 @@ | |||
|
|
|||
| Twin twin = null; | |||
|
|
|||
| _ = this.mockDeviceService.Setup(c => c.GetDevice(It.IsAny<string>())) | |||
| .ReturnsAsync((Device)null); | |||
Check warning
Code scanning / CodeQL
Useless upcast
hocinehacherouf
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?