Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/870 edge models creation/edition page #892

Merged
merged 47 commits into from
Aug 19, 2022
Merged

Feature/870 edge models creation/edition page #892

merged 47 commits into from
Aug 19, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Jun 30, 2022 •
edited by kbeaugrand
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 changed the title Issue#870 edge models creation/edition page Feature/Issue#870 edge models creation/edition page Jul 2, 2022
@Sben65 Sben65 changed the title Feature/Issue#870 edge models creation/edition page Feature/870 edge models creation/edition page Jul 2, 2022
@hocinehacherouf hocinehacherouf force-pushed the issue#870_edge_models_creation/edition_page branch from 5cdba82 to b87da66 Compare August 3, 2022 12:09
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Base: 85.47% // Head: 85.93% // Increases project coverage by +0.45% 🎉

Coverage data is based on head (e84837f) compared to base (2e66159).
Patch coverage: 90.30% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   85.47%   85.93%   +0.45%     
==========================================
  Files         180      194      +14     
  Lines        5909     6471     +562     
==========================================
+ Hits         5051     5561     +510     
- Misses        858      910      +52
Impacted Files Coverage Δ
...Pages/EdgeModels/EdgeModule/ModuleDialogTab2.razor 100.00% <ø> (ø)
...Pages/EdgeModels/EdgeModule/ModuleDialogTab3.razor 100.00% <ø> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 94.44% <ø> (ø)
...THub.Portal/Server/Factories/TableClientFactory.cs 42.42% <0.00%> (-4.25%) ⬇️
...Client/Pages/EdgeModels/CreateEdgeModelsPage.razor 73.75% <73.75%> (ø)
...Portal/Client/Validators/IoTEdgeModuleValidator.cs 73.91% <73.91%> (ø)
.../Client/Pages/EdgeModels/EdgeModelDetailPage.razor 76.69% <76.69%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 83.62% <88.05%> (-3.37%) ⬇️
...al/Client/Pages/EdgeModels/EdgeModelListPage.razor 88.88% <88.88%> (ø)
...lient/Pages/EdgeModels/DeleteEdgeModelDialog.razor 94.44% <94.44%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 3, 2022
View reviewed changes
src/AzureIoTHub.Portal/Server/Controllers/v1.0/EdgeDeviceModelsController.cs Fixed Show fixed Hide fixed
src/AzureIoTHub.Portal/Server/Services/ConfigService.cs
Comment on lines +232 to +181
catch (Exception e)
{
throw new InternalServerErrorException("Unable to create configuration.", e);
}

Check notice

Code scanning / CodeQL

Generic catch clause

Generic catch clause.
@Sben65 Sben65 force-pushed the issue#870_edge_models_creation/edition_page branch from b87da66 to 321ace3 Compare August 10, 2022 10:04
@Sben65 Sben65 force-pushed the issue#870_edge_models_creation/edition_page branch 2 times, most recently from 3cc3995 to 2d94e9f Compare August 11, 2022 15:59
@Sben65 Sben65 force-pushed the issue#870_edge_models_creation/edition_page branch from 4914ea1 to fea02ba Compare August 17, 2022 12:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 17, 2022
View reviewed changes
src/AzureIoTHub.Portal.Tests.Unit/Client/Pages/EdgeModels/CreateEdgeModelsPageTest.cs Outdated

_ = this.mockSnackbarService
.Setup(c => c.Add(It.IsAny<string>(), Severity.Success, It.IsAny<Action<SnackbarOptions>>()))
.Returns((Snackbar)null);

Check warning

Code scanning / CodeQL

Useless upcast

There is no need to upcast from [null](1) to [Snackbar](2) - the conversion can be done implicitly.
@Sben65 Sben65 force-pushed the issue#870_edge_models_creation/edition_page branch from 7bf9f83 to 88de54c Compare August 19, 2022 06:56
kbeaugrand
kbeaugrand requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed orally, please see and remove JsonProperty(PropertyName = ...) attributes when not needed

src/AzureIoTHub.Portal/Server/Services/ConfigService.cs Outdated Show resolved Hide resolved
src/AzureIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule.cs Show resolved Hide resolved
src/AzureIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule/EdgeAgentPropertiesDesired.cs Show resolved Hide resolved
This was linked to issues Aug 19, 2022
Bug: Edge Model - Fix typos #1106
Closed
Bug: Edge Models - Module image URI should be asked when adding a module #1083
Closed
Bug: Edge Model Edition - When adding a new module, module name and uri text box not available #1105
Closed
Bug: Edge Models - Remove Version #1080
Closed
Sben65 added 24 commits August 19, 2022 16:01
@Sben65
fix module dialog unit test
7ef34c6
@Sben65
add update edge model
9d9d315
@Sben65
add configHelper test.
813cc04
@Sben65
add unit test on edgeModelServiceTest
dee8415
@Sben65
delete useless test
63b79f4
@Sben65
add new test on EdgeModelClientServiceTest
05f3cfc
@Sben65
add new unit test on EdgeModelsControllerTest
00ab50b
@Sben65
add new test on configServiceTest
822c959
@Sben65
add new test
56e2d8f
@Sben65
add test on edgeModelsListPageTest
b38327e
@Sben65
add new test on edgeModelListPage
50f8f2a
@Sben65
fix error
0c75cbb
@Sben65
fix code scanning alert
0e98131
@Sben65
add test on createEdgeModelPage
6619f97
@Sben65
Bug fix #1080 and bug fix #1083
68882ac
@Sben65
add unit test on deleteEdgeModelDialog
7f2d61d
@Sben65
add new test on createEdgeModelPage
513889e
@Sben65
add new test on edgeModelService
8208add
@Sben65
add EdgeModelDetailPage unit test
63bb955
@Sben65
add new test to ConfigHelpers
fc9606a
@Sben65
fix unit test
381d213
@Sben65
fix bug: Edge Model Edition - When adding a new module, module name a…
e4c10c5 
…nd uri text box not available
@Sben65
remove udeless code
5dd1877
@Sben65
resizing moduleDialog
e84837f
@Sben65 Sben65 force-pushed the issue#870_edge_models_creation/edition_page branch from 18a95a7 to e84837f Compare August 19, 2022 14:02
@kbeaugrand kbeaugrand marked this pull request as ready for review August 19, 2022 14:15
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 19, 2022 14:15
@kbeaugrand kbeaugrand merged commit 91e4499 into main Aug 19, 2022
@kbeaugrand kbeaugrand deleted the issue#870_edge_models_creation/edition_page branch August 19, 2022 14:17
@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Sben65 @kbeaugrand