Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #88 rename DefaultEnrollmentGroupe to DefaultEnrollmentGroup #92

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Jan 24, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Checklist before merge

Developer's responsibilities

  • This pull request merges to main
  • Approved by at least one developer
  • Pull request build has passed
  • Staging app has been deployed successfully

Product Owner's responsibilities

  • No issues have been found on staging environment
  • Product Owner has approved the release

@Sben65 Sben65 requested a review from audserraCGI January 24, 2022 09:40
@audserraCGI audserraCGI merged commit a5a7763 into main Jan 24, 2022
audserraCGI added a commit that referenced this pull request Jan 24, 2022
* fix #88 (#92)

Co-authored-by: ben salim <salim.benahben@cgi.com>

* Migrate to CGI-FR Organization (#93)

* Reset fields if the "Model type" field is cleared

* Prevent device creation if no model is selected

Co-authored-by: salim ben ahben <40862545+Sben65@users.noreply.github.com>
Co-authored-by: ben salim <salim.benahben@cgi.com>
Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
@kbeaugrand kbeaugrand deleted the issue_#88_rename_DefaultEnrollmentGroupe branch January 24, 2022 17:18
audserraCGI pushed a commit that referenced this pull request Jan 25, 2022
* fix #88 (#92)

Co-authored-by: ben salim <salim.benahben@cgi.com>

* fix #76 check the DevEui at device creation
audserraCGI pushed a commit that referenced this pull request Jan 26, 2022
* fix #88 (#92)

Co-authored-by: ben salim <salim.benahben@cgi.com>

* fix #76 check the DevEui at device creation

* fix #72

* fix #72
Sben65 added a commit that referenced this pull request Jan 27, 2022
…gs (#116)

* fix #88 (#92)

Co-authored-by: ben salim <salim.benahben@cgi.com>

* fix #76 check the DevEui at device creation

* adding scroll in the logs modal

* fix #103

* fix #76 check the DevEui at device creation

* adding scroll in the logs modal

* fix #103

* add of missing code

* add of missing code

* code cleanup

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants