-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a RegexMask on command frame to prevent non-hexadecimal characters #949
Add a RegexMask on command frame to prevent non-hexadecimal characters #949
Conversation
Codecov Report
@@ Coverage Diff @@
## main #949 +/- ##
==========================================
+ Coverage 84.36% 85.82% +1.46%
==========================================
Files 174 174
Lines 5633 5635 +2
==========================================
+ Hits 4752 4836 +84
+ Misses 881 799 -82
Continue to review full report at Codecov.
|
3f7c57b
to
13f6cc8
Compare
src/AzureIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/CreateLoRaDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
d32ab4d
to
ad40344
Compare
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
...eIoTHub.Portal.Server.Tests.Unit/Pages/DevicesModels/LoRaWAN/EditLoraDeviceModelPageTests.cs
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also add Validation to the DeviceModelCommand
to validate the input by the API too
src/AzureIoTHub.Portal/Shared/Models/v1.0/LoRaWAN/DeviceModelCommand.cs
Outdated
Show resolved
Hide resolved
…ommand.cs Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
Description
What's new?
What kind of change does this PR introduce?