Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification device tag setting #972

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

ChristopheRib63
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Feature

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #972 (dd3e826) into main (b2eb6f6) will decrease coverage by 0.02%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   85.89%   85.87%   -0.03%     
==========================================
  Files         173      172       -1     
  Lines        5600     5613      +13     
==========================================
+ Hits         4810     4820      +10     
- Misses        790      793       +3     
Impacted Files Coverage Δ
.../Client/Services/DeviceTagSettingsClientService.cs 46.66% <14.28%> (-53.34%) ⬇️
....Portal/Client/Pages/Settings/DeviceTagsPage.razor 85.33% <88.57%> (+2.52%) ⬆️
...rtal/Shared/Models/v1.0/LoRaWAN/LoRaDeviceModel.cs 100.00% <0.00%> (ø)
...al/Shared/Models/v1.0/LoRaWAN/LoRaDeviceDetails.cs 100.00% <0.00%> (ø)
...ortal/Shared/Models/v1.0/LoRaWAN/LoRaDeviceBase.cs
.../Shared/Models/v1.0/LoRaWAN/LoRaDeviceModelBase.cs
...ub.Portal/Server/Services/LoRaWANCommandService.cs 97.26% <0.00%> (ø)
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 90.12% <0.00%> (+0.37%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2eb6f6...dd3e826. Read the comment docs.

@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review July 29, 2022 13:19
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner July 29, 2022 13:19
@kbeaugrand kbeaugrand force-pushed the feature/886_device_tag_setting branch from dd3e826 to 8d35ebb Compare July 29, 2022 13:22
@kbeaugrand kbeaugrand merged commit 81863e6 into main Jul 29, 2022
@kbeaugrand kbeaugrand deleted the feature/886_device_tag_setting branch July 29, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants