Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save and duplicate device #616 #997

Merged
merged 8 commits into from
Jul 29, 2022
Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #997 (37e7d1c) into main (526b04e) will decrease coverage by 0.69%.
The diff coverage is 59.55%.

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   85.97%   85.28%   -0.70%     
==========================================
  Files         172      174       +2     
  Lines        5597     5748     +151     
==========================================
+ Hits         4812     4902      +90     
- Misses        785      846      +61     
Impacted Files Coverage Δ
...ient/Pages/Devices/DeviceToDuplicateSelector.razor 39.47% <39.47%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 64.93% <40.00%> (-5.07%) ⬇️
...Portal/Client/Pages/Devices/CreateDevicePage.razor 63.25% <53.42%> (-3.42%) ⬇️
...THub.Portal/Client/Services/DeviceLayoutService.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526b04e...37e7d1c. Read the comment docs.

@hocinehacherouf hocinehacherouf force-pushed the feature/616_save_and_duplicate branch from e523e0b to ea45703 Compare July 29, 2022 09:00
@hocinehacherouf hocinehacherouf marked this pull request as ready for review July 29, 2022 09:54
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner July 29, 2022 09:54
@kbeaugrand kbeaugrand merged commit 9d6efa0 into main Jul 29, 2022
@kbeaugrand kbeaugrand deleted the feature/616_save_and_duplicate branch July 29, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants