Feature/php 81 #178
Open
Feature/php 81 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
reviewed
Apr 3, 2023
Comment on lines
+21
to
+22
| final const PAGE_NUMBER = 0; | ||
| final const PAGE_SIZE = 10; |
There was a problem hiding this comment.
Suggested change
| final const PAGE_NUMBER = 0; | |
| final const PAGE_SIZE = 10; | |
| private const PAGE_NUMBER = 0; | |
| private const PAGE_SIZE = 10; |
There was a problem hiding this comment.
But please ensure that it's not used externally.
Comment on lines
+24
to
+25
| final CONST PAGE_SIZE_MIN = 0; | ||
| final const PAGE_SIZE_MAX = 1000; |
There was a problem hiding this comment.
Suggested change
| final CONST PAGE_SIZE_MIN = 0; | |
| final const PAGE_SIZE_MAX = 1000; | |
| private CONST PAGE_SIZE_MIN = 0; | |
| private const PAGE_SIZE_MAX = 1000; |
| @@ -148,7 +148,7 @@ public function actionIndex() | |||
| * @throws \yii\base\InvalidConfigException | |||
| * @throws ForbiddenHttpException | |||
| */ | |||
| public function actionCreate() | |||
| public function actionCreate(): array|\api\modules\v1\models\customer\CustomerEx | |||
| @@ -238,7 +238,7 @@ public function actionCreate() | |||
| * @return array|\api\modules\v1\models\customer\CustomerEx | |||
| * @throws ForbiddenHttpException | |||
| */ | |||
| public function actionView($id) | |||
| public function actionView($id): array|\api\modules\v1\models\customer\CustomerEx | |||
| @@ -325,7 +325,7 @@ public function actionView($id) | |||
| * @throws \yii\base\InvalidConfigException | |||
| * @throws ForbiddenHttpException | |||
| */ | |||
| public function actionUpdate($id) | |||
| public function actionUpdate($id): array|\api\modules\v1\models\customer\CustomerEx | |||
| @@ -38,8 +38,8 @@ public function behaviors(): array | |||
|
|
|||
| public function init(): void | |||
| { | |||
| $this->on(self::EVENT_AFTER_UPDATE, [$this, 'createJobIfNeeded']); | |||
| $this->on(self::EVENT_AFTER_INSERT, [$this, 'createJobIfNeeded']); | |||
| $this->on(self::EVENT_AFTER_UPDATE, $this->createJobIfNeeded(...)); | |||
| @@ -53,7 +53,7 @@ public function scenarios(): array | |||
|
|
|||
| public function init(): void | |||
| { | |||
| $this->on(self::EVENT_BEFORE_INSERT, [$this, 'orderHistoryPopulate']); | |||
| $this->on(self::EVENT_BEFORE_INSERT, $this->orderHistoryPopulate(...)); | |||
There was a problem hiding this comment.
Looks wrong. Let's search for (...) everywhere.
| @@ -448,6 +449,8 @@ public function actionClone($id) | |||
| */ | |||
| public function actionDelete($id) | |||
| { | |||
| $model = null; | |||
| @@ -448,6 +449,8 @@ public function actionClone($id) | |||
| */ | |||
| public function actionDelete($id) | |||
| { | |||
| $model = null; | |||
| $transaction = null; | |||
There was a problem hiding this comment.
No need for it. It is initialized properly when used. Similar in
| @@ -772,7 +775,7 @@ public function actionImport() | |||
|
|
|||
| $model = new OrderImport(); | |||
|
|
|||
| if (count($customers) === 1) { | |||
| if ((is_countable($customers) ? count($customers) : 0) === 1) { | |||
There was a problem hiding this comment.
$customers can't be non-array, no need for this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.