Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bit misspell comments #10

Open
wants to merge 7 commits into
base: V1.2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/z_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def get_z_order(x, y, z):
1- Split all coordinates by 3 (add 2 zeros between bits)
2- Shift bits left by 1 for y and 2 for z
3- Interleave x, shifted y, and shifted z
The mordon order is the final interleaved bit sequence
The Morton order is the final interleaved bit sequence

:param x: x coordinates
:param y: y coordinates
Expand Down
4 changes: 2 additions & 2 deletions segmentation/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def _group_to_str(group: List[str]) -> str:
Args:
group (list[str]): list of parameter name suffixes.
Returns:
str: formated string.
str: formatted string.
"""
if len(group) == 0:
return ""
Expand All @@ -255,4 +255,4 @@ def _named_modules_with_dup(
if module is None:
continue
submodule_prefix = prefix + ("." if prefix else "") + name
yield from _named_modules_with_dup(module, submodule_prefix)
yield from _named_modules_with_dup(module, submodule_prefix)
2 changes: 1 addition & 1 deletion segmentation/models/z_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def get_z_order(x, y, z):
1- Split all coordinates by 3 (add 2 zeros between bits)
2- Shift bits left by 1 for y and 2 for z
3- Interleave x, shifted y, and shifted z
The mordon order is the final interleaved bit sequence
The Morton order is the final interleaved bit sequence

:param x: x coordinates
:param y: y coordinates
Expand Down
2 changes: 1 addition & 1 deletion segmentation/pointnet_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def forward(self, xyz, points, seed_idx=None):
return new_xyz, new_points_concat


# NoteL this function swaps N and C
# Note: this function swaps N and C
class PointNetFeaturePropagation(nn.Module):
def __init__(self, in_channel, mlp):
super(PointNetFeaturePropagation, self).__init__()
Expand Down
6 changes: 3 additions & 3 deletions segmentation/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def shuffle_points(batch_data):
return batch_data[:,idx,:]

def rotate_point_cloud(batch_data):
""" Randomly rotate the point clouds to augument the dataset
""" Randomly rotate the point clouds to augment the dataset
rotation is per shape based along up direction
Input:
BxNx3 array, original batch of point clouds
Expand All @@ -64,7 +64,7 @@ def rotate_point_cloud(batch_data):
return rotated_data

def rotate_point_cloud_z(batch_data):
""" Randomly rotate the point clouds to augument the dataset
""" Randomly rotate the point clouds to augment the dataset
rotation is per shape based along up direction
Input:
BxNx3 array, original batch of point clouds
Expand Down Expand Up @@ -155,7 +155,7 @@ def rotate_point_cloud_by_angle_with_normal(batch_data, rotation_angle):
BxNx6 array, original batch of point clouds with normal
scalar, angle of rotation
Return:
BxNx6 array, rotated batch of point clouds iwth normal
BxNx6 array, rotated batch of point clouds with normal
"""
rotated_data = np.zeros(batch_data.shape, dtype=np.float32)
for k in range(batch_data.shape[0]):
Expand Down