ensure consistency in use of nSnow and nSoil #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martynpclark
added a commit
that referenced
this pull request
May 21, 2015
ensure consistency in use of nSnow and nSoil
wknoben
pushed a commit
that referenced
this pull request
Nov 17, 2024
Resolving segmentation errors for gcc-13+ builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up nSnow and nSoil to ensure consistency and avoid re-computing the number of snow and soil layers when not needed.
We do still re-compute nSnow and nSoil in layer_merge.f90 and layerDivide.f90 -- this is necessary because the number of layers changes.
As a safety check we re-compute nSnow and nSoil in coupled_em.f90 -- this should not increase the computational burden substantially since the operations occur outside the main solver.
Importantly, the main process routines:
snowLiqFlx
soilLiqFlx
ssdNrgFlx
vegNrgFlx
vegSWrad
all share nSnow and nSoil through the data structure.