Latest updates to develop-sundials that include enthalpy options #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bly remove lookup option
…split_select loop.
…py related) -- this means maxiter param does not do anything
… better (more accurate, faster)
…it_select loop in opSplittin.
Hotfix for error message issue in varSubstep.
…ents, shouldn't change anything
Hotfix for error message truncation problem
Update cmakelists to include c netcdf library for actors.
* ent_state: (77 commits) clean up aquiferIni decision change lyr_wght change to snow balance is realMissing if never a snow state in the data window, not just at end remove scaledBalance variable, decision name clarify-- now closedForm, enthalpyFormLU, or enthalpyForm banded enthalpy Jacobian needed different index account for missing vegetation in jacobian a bit more Brent speed up calculate snow merge detection outside of brent better bounds for brent function need to put snow merge condition on enthalpy as well as temperature need to change root finding to be on enthalpy ... # Conflicts: # build/source/driver/summa_setup.f90 # build/source/engine/coupled_em.f90 # build/source/engine/enthalpyTemp.f90 # build/source/engine/eval8summaWithPrime.f90 # build/source/engine/layerMerge.f90 # build/source/engine/systemSolv.f90 # build/source/engine/varSubstep.f90 # utils/bal_per_GRU.py
…parameters to match V3. I have added some new files to Summa-Actors and now leverage the restart and setup files from summa. I have also edited the order of paremeters for vegPhenlgy to match what is now a pull request in V3
Edit cmake lists file to reflect updates to summa-actors, and adjust …
…lit, can lose them in the middle of a run when snow buries the canopy
…plitting with IDA
|
Merging as per Ashley's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes refactor and clean up of the opSplittin routines from Sean, the option to have
nrgConserv = closedForm(traditional method) ornrgConserv = enthalpyFDornrgConserv = enthalpyFDlu, the enthalpy method to conserve energy using the soil enthalpy from the analytical solution or the lookup tables, respectively.New output variables that give balance errors can be computed by adding to the outputControl.txt
Other notable changes are the constraints scale the linesearch in
numMethod = numrecornumMethod = kinsolonly on the state variable they are violating, not the entire vector, and the feasiblity/constraints have been corrected for previous bugs in their values. Two end member cases that led to decisions being based on unintialized values (one in the SummaBE solve loop in summaSolv, one in opSplittin) have been fixed, as well as 6 cases of allocation type errors that caused gcc13 to have an internal compiler segfault.