Skip to content

Conversation

xdoardo
Copy link
Collaborator

@xdoardo xdoardo commented Aug 22, 2025

I think I disabled the CI tasks from rust-lang/rust. I want to check if it is true.
I might use this PR to do some tests: I'd like to see if we can have a simple CI job that does sanity checks, such as running tidy and compiling rustc on a selection of target machines using CHERIoT-Platform's LLVM.

Edit: this is done by changing the default remote and branch of the llvm-project submodule in Rust to the ones from CHERIoT-platform, which might be a debatable choice. Also, notice that this commit only sets up the submodule and adds sanity checks in CI, but does not change the Rust/C++ code in rustc that re-exports and links to the LLVM API: CI is therefore bound to fail for now :)

@xdoardo xdoardo force-pushed the cheri-ci branch 30 times, most recently from 6f4e2d3 to aab3649 Compare August 22, 2025 15:05
@xdoardo xdoardo force-pushed the cheri-ci branch 6 times, most recently from 6375f63 to c707d83 Compare August 25, 2025 09:12
@xdoardo xdoardo changed the title CI: Test what happens on PRs Use CHERIoT-Platform's LLVM + CI to check it Aug 25, 2025
@xdoardo xdoardo force-pushed the cheri-ci branch 10 times, most recently from 57e7b90 to 1384154 Compare August 25, 2025 12:21
@xdoardo
Copy link
Collaborator Author

xdoardo commented Aug 25, 2025

Alright, CI is now trying to run ./x check using CHERIoT-Platform's LLVM. Of course, it fails because we didn't patch the API yet.

.cirrus.yml Outdated
- export CCACHE_REMOTE_STORAGE="http://${CIRRUS_HTTP_CACHE_HOST}/${CIRRUS_OS}/"
- export CCACHE_REMOTE_ONLY=1
- env
test_script: CC="clang" CXX="clang" ./x check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CXX should be clang++

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

Copy link
Collaborator

@seharris seharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.
Do we need to talk about what CI service to use at some point?

@xdoardo
Copy link
Collaborator Author

xdoardo commented Aug 26, 2025

Currently it uses Cirrus CI, which is already used in the llvm-project repo.

@xdoardo xdoardo merged commit 46e1621 into CHERIoT-Platform:beta Aug 26, 2025
1 of 2 checks passed
xdoardo pushed a commit to xdoardo/cheri-rust that referenced this pull request Sep 1, 2025
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [CHERIoT-Platform#1 of Batch CHERIoT-Platform#2]

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
xdoardo pushed a commit to xdoardo/cheri-rust that referenced this pull request Sep 1, 2025
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [CHERIoT-Platform#2 of Batch CHERIoT-Platform#2]

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
xdoardo pushed a commit that referenced this pull request Sep 29, 2025
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2]

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants