-
Notifications
You must be signed in to change notification settings - Fork 1
Use CHERIoT-Platform's LLVM + CI to check it #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f4e2d3
to
aab3649
Compare
6375f63
to
c707d83
Compare
57e7b90
to
1384154
Compare
Alright, CI is now trying to run |
.cirrus.yml
Outdated
- export CCACHE_REMOTE_STORAGE="http://${CIRRUS_HTTP_CACHE_HOST}/${CIRRUS_OS}/" | ||
- export CCACHE_REMOTE_ONLY=1 | ||
- env | ||
test_script: CC="clang" CXX="clang" ./x check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CXX should be clang++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
Do we need to talk about what CI service to use at some point?
Currently it uses Cirrus CI, which is already used in the llvm-project repo. |
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [CHERIoT-Platform#1 of Batch CHERIoT-Platform#2] Part of rust-lang/rust#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [CHERIoT-Platform#2 of Batch CHERIoT-Platform#2] Part of rust-lang/rust#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2] Part of rust-lang/rust#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
I think I disabled the CI tasks from rust-lang/rust. I want to check if it is true.
I might use this PR to do some tests: I'd like to see if we can have a simple CI job that does sanity checks, such as running
tidy
and compilingrustc
on a selection of target machines using CHERIoT-Platform's LLVM.Edit: this is done by changing the default remote and branch of the llvm-project submodule in Rust to the ones from CHERIoT-platform, which might be a debatable choice. Also, notice that this commit only sets up the submodule and adds sanity checks in CI, but does not change the Rust/C++ code in rustc that re-exports and links to the LLVM API: CI is therefore bound to fail for now :)