Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting bcs #205

Merged
merged 2 commits into from
Mar 28, 2021
Merged

deleting bcs #205

merged 2 commits into from
Mar 28, 2021

Conversation

krober10nd
Copy link
Collaborator

  • improving make_bc delete method by enabling user to pass boundary index number without having to click on figure.
  • weirs are now correctly deleted from the msh object.

* improving `make_bc` delete method by enabling user to pass boundary index number without having to click on figure. 
* weirs are now correctly deleted from the `msh` object.
* documenting changes in changelog
Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krober10nd krober10nd merged commit 315693e into Projection Mar 28, 2021
@krober10nd krober10nd deleted the delete_bcs branch March 28, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants