-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding Manning's landcover option (CCAP and NLCD) #221
Conversation
Talking with @zcobell over the months regarding this land cover business issue, it’s often better to use a grid scale averaging approach and my experience corroborates this as well. So perhaps we could look into enabling that capability here? I generally need to smooth out these small scale features from both the dem and the landcover fields in order to get good overland flooding. |
Yeah it would be easy to implement gridscale averaging since it calls the "interp" function already. We can just change method from nearest to CA. So if just add a varargin to this for the interp method type? |
Actually it won't be that easy since it is using the mapping from the integer land type classes. If we somehow convert the land class to Mannings first then it will be easy. |
Yes perhaps convert to Manning’s and then treat it as raster DEM |
Could make the LUTs a kwarg in GridData and then if the LUT is passed it’s used to convert the Integer to a continuous field. |
LUTs may be generally useful to apply for example you could create your nodal attributes based on bathymetry |
My other comment is to estimate the size of the data we are going to read in when interpolating and do a loop to prevent the user from exceeding RAM. This could just use the existing K index feature. I’ll have time to work on this today |
Okay check out this...with NLCD landcover database on a subset of a mesh.
produces this And you can now use all the
What I find is that typically the NLCD rasters come on what we've termed "irregular" structured grids and the way |
- renaming nlcd/ccap_class to ncld/ccap_mannings in nlcd/ccap.mat - adding nlcd/ccap_classifications string to describe values in nlcd/ccap_mannings to nlcd/ccap.mat - end of nlcd/ccap_class should be the mannings value not the index - adding checking for NaNs to make the default_val since points could be outside of the landuse data
…r Galveston (can be found on google drive)
Okay looks good. Now we need to run all examples and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I see for the future is the memory usage associated with FindLinearIdx
. All tests and examples passed successfully.
@WPringle do you recall where we obtained the Mannings n lookup table from landcover categories? |
Did we just get it from: Bunya, S., et al (2010). A High-Resolution Coupled Riverine Flow, Tide, Wind, Wind Wave, and Storm Surge Model for Southern Louisiana and Mississippi. Part I: Model Development and Validation. Monthly Weather Review, 138(2), 345–377. https://doi.org/10.1175/2009MWR2906.1? |
Also maybe from the f13 builder at adcirc.org? f13builderv8.3.zip |
I believe the CCAP was first used in Casey's Gustav paper. We've also used it for the Louisiana Master Plan since 2010 so it's possible you grabbed it from one of those too. I'd start with Casey's paper, though. |
This seems to ring a bell. https://www.xmswiki.com/wiki/Landuse_Raster_to_Mannings_N_Tool |
Fixed
Make_f15
can now contain "major8" in addition to other constituents in the string/cell arrayChanged
Calc_NLCD_Mannings
toCalc_Mannings_Landcover
and making option for 'ccap' landcover type in addition to 'nlcd' (default)