Build and Upload PAM OAuth RPMs (Inf-794) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uploads can be found at the bottom of the portion of the Actions summary page. The action checks out the code and from the rpm directory builds the container pamoauth2device-rpm-build. The docker run command creates a volume that maps /data inside the container to the .workspace variable which is the file path of the root directory of the current repo on the github actions runner. There was a permission issue between the user of the container and the github actions user where github actions user could not copy anything from inside the container. Setting the container user as root solved the problem but that may not be the appropriate work around. The upload artifact action pulls the build rpms from the .workspace/RPMS path.
|
@jtakaki-matc I generally don't love making everything run as root. Instead of dumping the contents of |
|
@brianhlin I've got green check marks for this update, I think that's better?? |
brianhlin
reviewed
Jun 7, 2023
Remove uid and gid from docker run command in workflow
|
@brianhlin Updated Dockerfile! |
Co-authored-by: Brian Lin <brianhlin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uploads can be found at the bottom of the portion of the Actions summary page. The action checks out the code and from the rpm directory builds the container pamoauth2device-rpm-build. The docker run command creates a volume that maps /data inside the container to the .workspace variable which is the file path of the root directory of the current repo on the github actions runner. There was a permission issue between the user of the container and the github actions user where github actions user could not copy anything from inside the container. Setting the container user as root solved the problem but that may not be the appropriate work around. The upload artifact action pulls the build rpms from the .workspace/RPMS path.