-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): build and publish flatpak on release #123
chore(ci): build and publish flatpak on release #123
Conversation
docs/building-from-source.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, i need to discard these changes.
.github/workflows/release.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in light of #122, this artifact upload needs to change to uploading several files:
- the binary
- the icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- need to add more file sources for the desktop file and icons
I'll wait for #122 to get merged with any references to icons before moving ahead with this one. |
- name: lampray | ||
buildsystem: simple | ||
build-commands: | ||
- echo "skipping" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is temporary?
build-commands: | ||
- echo "skipping" | ||
sources: | ||
- type: file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be good to include the entire Lampray repository as a source, like OBS does: https://github.com/obsproject/obs-studio/blob/b45a73296f4f898e2ed455023020058075c30bab/build-aux/com.obsproject.Studio.json#L105
@CHollingworth ok retargeted. next steps:
|
Apologies for the wait. |
Lampray will now build and publish flatpaks.
Furthermore to facilitate hallway testing, when you comment in a PR
/build
a PRs can have a flatpak generated as a artifact (not a release) and you'll see a comment link to the created preview flatpak.This is useful for:
Todo