Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build and publish flatpak on release #123

Conversation

airtonix
Copy link
Contributor

@airtonix airtonix commented Jan 22, 2024

Lampray will now build and publish flatpaks.

Furthermore to facilitate hallway testing, when you comment in a PR /build a PRs can have a flatpak generated as a artifact (not a release) and you'll see a comment link to the created preview flatpak.

This is useful for:

  • the release PRs to get a preview of what a release is going to be like.
  • fix and feature PRs: test if your changes are helpful.

Todo

  • test and ensure that the preview workflow only runs when the chatops command is used.
  • rename the flatpak id for previews so it's different from the release build
  • work out how publishing flatpaks work: what detaisl are required etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, i need to discard these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in light of #122, this artifact upload needs to change to uploading several files:

  • the binary
  • the icons

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#122

  • need to add more file sources for the desktop file and icons

@airtonix
Copy link
Contributor Author

I'll wait for #122 to get merged with any references to icons before moving ahead with this one.

- name: lampray
buildsystem: simple
build-commands:
- echo "skipping"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is temporary?

build-commands:
- echo "skipping"
sources:
- type: file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to include the entire Lampray repository as a source, like OBS does: https://github.com/obsproject/obs-studio/blob/b45a73296f4f898e2ed455023020058075c30bab/build-aux/com.obsproject.Studio.json#L105

@airtonix airtonix changed the base branch from master to flatpak-test February 4, 2024 03:19
@airtonix
Copy link
Contributor Author

airtonix commented Feb 4, 2024

@CHollingworth ok retargeted.

next steps:

  1. merge this to the tmp feature branch. flatpak-test
  2. @Plarpoon will take over ensuring that we can make a flatpak build. We'll post examples flatpaks.
  3. once we see that we have working flatpak builds, we'll be able to continue working on getting github actions to build and release the flatpak release.

@CHollingworth CHollingworth merged commit 27c9f50 into CHollingworth:flatpak-test Mar 28, 2024
2 checks passed
@CHollingworth
Copy link
Owner

Apologies for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants