feat: Re-enable rar support #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have not had any luck extracting the rar3 test file I grabbed from https://github.com/ssokolow/rar-test-files, but the rar5 file seems to work fine with this setup.
|
Ill tentatively re-add this for 2.0. seems to fail on some of my test files but some support is better than none! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables attempted support for .rar files. It will attempt to decompress with Rar5 first, and fallback to the older Rar method if that fails.
If both methods fail, the user will get an error notification with the error messages from both attempts.
I tested with the main .rar files from https://github.com/ssokolow/rar-test-files. This successfully extracted the
testfile.rar5.rarfile, but still fails on thetestfile.rar3.rarfile, so support will probably still be spotty.