Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modifications required in documentation #951

Closed
JFLemieux73 opened this issue May 8, 2024 · 3 comments · Fixed by #953
Closed

Minor modifications required in documentation #951

JFLemieux73 opened this issue May 8, 2024 · 3 comments · Fixed by #953

Comments

@JFLemieux73
Copy link
Contributor

  • Remove sentence: 'Here we assume that the top layer is thin enough.' in section 2.1
  • the eqs in section 2.5 assume that the ice is in the northern hemisphere (f>0) for the water stress term when the turning angle is not zero. Need to mention it or modify the eqs to have a 'sign' variable for some terms (as done in the code).
@eclare108213
Copy link
Contributor

JF's comment from #952:

    The eqs in the doc in section 2.5 are correct for the northern hemisphere (with fm>0) for the water stress term. Hence, in the doc, waterx = uwcos(theta) - vwsin(theta). In the code, however, waterx = uwcos(theta) - vwsin(theta)*sign(c1,fm). We could do:

we add sign(c1,fm) in the doc for waterx, watery and ccb. But I find these eqs are already quite busy.
we mention that the formulation of the water stress is for the northern hemisphere and that the sin(theta) terms are multiplied by -1 in the code when the ice is in the southern hemisphere.

The documentation does not appear to define what all the symbols are in the equations, e.g. theta. Since it is already simplified and the details are (or should be!) in the papers, I suggest putting a plus-or-minus symbol before the sin(theta) term and add a sentence that says something like "the sign of the sin(theta) term is hemisphere-dependent."

@apcraig
Copy link
Contributor

apcraig commented May 13, 2024

So plus/minus goes in front of just the sin(theta) term associated with the ocean velocity turning term? Is that right?

Should I add plus/minus to all equations or just to equation 2, note that it's hemisphere dependent. Then also note the equations that follow do not have plus/minus but should?

@eclare108213
Copy link
Contributor

Based on JF's comments, I think it would be on both equations in (2) for the velocity components, in front of (Vw-v)sin(theta). Search for 'sign' in ice_dyn_shared.F90.

apcraig added a commit to apcraig/CICE that referenced this issue May 13, 2024
ice_dyn_evp.F90.  Do an unmasked grid_average_X2Y when averaging
from uvelE to uvel and from vvelN to vvel instead of a masked average.
The masking is handled separately.  This change is bit-for-bit and
saves a few flops.  Closes CICE-Consortium#952.

Update the documentation to add the hemispheric sign dependence in the
water stress terms in the dynamics equations.  Closes CICE-Consortium#951.
apcraig added a commit that referenced this issue May 14, 2024
Update the calculation of uvel and vvel in subroutine evp in file ice_dyn_evp.F90. Do an unmasked grid_average_X2Y when averaging from uvelE to uvel and from vvelN to vvel instead of a masked average. The masking is handled separately. This change is bit-for-bit and saves a few flops. Closes #952.

Update the documentation to add the hemispheric sign dependence in the water stress terms in the dynamics equations. Closes #951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants