-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor modifications required in documentation #951
Comments
JF's comment from #952:
The documentation does not appear to define what all the symbols are in the equations, e.g. theta. Since it is already simplified and the details are (or should be!) in the papers, I suggest putting a plus-or-minus symbol before the sin(theta) term and add a sentence that says something like "the sign of the sin(theta) term is hemisphere-dependent." |
So plus/minus goes in front of just the sin(theta) term associated with the ocean velocity turning term? Is that right? Should I add plus/minus to all equations or just to equation 2, note that it's hemisphere dependent. Then also note the equations that follow do not have plus/minus but should? |
Based on JF's comments, I think it would be on both equations in (2) for the velocity components, in front of (Vw-v)sin(theta). Search for 'sign' in ice_dyn_shared.F90. |
ice_dyn_evp.F90. Do an unmasked grid_average_X2Y when averaging from uvelE to uvel and from vvelN to vvel instead of a masked average. The masking is handled separately. This change is bit-for-bit and saves a few flops. Closes CICE-Consortium#952. Update the documentation to add the hemispheric sign dependence in the water stress terms in the dynamics equations. Closes CICE-Consortium#951.
Update the calculation of uvel and vvel in subroutine evp in file ice_dyn_evp.F90. Do an unmasked grid_average_X2Y when averaging from uvelE to uvel and from vvelN to vvel instead of a masked average. The masking is handled separately. This change is bit-for-bit and saves a few flops. Closes #952. Update the documentation to add the hemispheric sign dependence in the water stress terms in the dynamics equations. Closes #951.
The text was updated successfully, but these errors were encountered: