Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix albedo initialization order of operations and update icepack #414

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 6, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Fix albedo initialization order of operations and update icepack
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran full test suite on conrad, 4 compilers, all bit-for-bit, results
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This issue never results in a restart problem in CICE, but the same problem did in Icepack, so we're fixing it here as well. This also includes the latest version of Icepack, which does not change the columnphysics but also includes this fix in the icepack driver.

@apcraig apcraig requested review from eclare108213 and dabail10 March 6, 2020 22:43
@apcraig apcraig merged commit 7e2a1d9 into CICE-Consortium:master Mar 6, 2020
@apcraig apcraig deleted the albedo_init_fix branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants