-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cell-centered ice velocity for high-freq wind stress calculation #576
Conversation
We need to fix the test combinations so that kdyn is on when highfreq is on. alt01 has kdyn=0 (off), as does boxdyn. I think we could just change alt01 to have kdyn=1. |
@eclare108213, would you like to update the alt01 test as part of this PR or do you prefer that be a separate PR? |
There's potentially a bigger problem with the alt01 and boxdyn tests which I need to look at more closely (why is kdyn =0 off for a 'dyn' box test?). If the other PR reviewers approve this PR as it is, then I think we should go ahead and merge it and keep moving forward. If I manage to look at the tests before then and see how to change them, then I might add that to this PR, but it's not necessary in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved upon visual inspection. One point to note is the problem of diffusive dynamic coupling through scalar grid points. That cannot be addressed in this PR which is a fix to an existing problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via visual inspection
I changed the alt01 test to turn dynamics on, in order to test the effects of changes in the highfreq calculation. As expected, they aren't BFB. Results of just the revised alt01 comparisons, with and without this code modification are here: |
Use interpolated, T-grid cell-centered ice velocity for high-frequency wind stress calculation instead of U-grid velocity
E. Hunke, based on modification to MPAS-seaice
https://github.com/CICE-Consortium/Test-Results/wiki/5a0a559aaf.badger.intel.21-03-13.231354.0
40-pe runs always fail on badger.
Addresses Step therm1 using vertex velocity instead of cell velocity #544.
This PR should change the answers for -s alt01 tests, because it alters the ice velocity used to calculate the wind stress when highfreq=T. However the ice dynamics is turned off for alt01 (kdyn=0), so the ice velocity is identically zero and the results are BFB. We need to fix the alt01 test.