Remove hc_jday and replace with "compute_days_between" for HYCOM forcing #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
HYCOM forcing specific. Use "compute_days_between" from the newly introduced ice_calendar. And remove hc_jday, which is not used anymore
@mhrib
@apcraig @eclare108213 @TillRasmussen
NOT done. However as DMI is the only one using this routine, I am confident, that my own checks is ok.
** update from automatic checks **
19 measured results of 19 total results
19 of 19 tests PASSED
0 of 19 tests PENDING
0 of 19 tests MISSING data
0 of 19 tests FAILED
HYCOM forcing specific only pull request: