Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to new ice_calendar in DMI NUOPC routines #598

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mhrib
Copy link
Contributor

@mhrib mhrib commented Apr 14, 2021

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Modify to use new ice_calendar in DMI NUOPC routines
  • Developer(s):
    @mhrib
  • Suggest PR reviewers from list in the column to the right.
    @apcraig @TillRasmussen @eclare108213
  • Please copy the PR test results link or provide a summary of testing completed below.
    Run coupled HYCOM-CICE test at DMI without any issues
    ** Automatic PR result **
    19 measured results of 19 total results
    19 of 19 tests PASSED
    0 of 19 tests PENDING
    0 of 19 tests MISSING data
    0 of 19 tests FAILED
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Modify to use new ice_calendar in DMI NUOPC routines:
CICE_InitMod, CICE_RunMod, CICE_FinalMod (no code changes, only cosmetic)
Inspired by similar changes to CMEPS NUOPC driver

@apcraig apcraig merged commit f462721 into CICE-Consortium:master Apr 14, 2021
@mhrib mhrib deleted the nuopc_dmi_calendar branch October 7, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants