Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cice.t-test.py to use cartopy instead of basemap. #742

Merged
merged 7 commits into from
Jul 31, 2022
Merged

Update cice.t-test.py to use cartopy instead of basemap. #742

merged 7 commits into from
Jul 31, 2022

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 31, 2022

PR checklist

  • Short (1 sentence) summary of your PR:
    Update cice.t-test.py to use cartopy instead of basemap.
  • Developer(s):
    daveh150
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This is #727 with one additional change. #727 will be closed.

This switches from basemap to cartopy and fixes missing data in the QC plots by using blockall to include land blocks in the decomposition.

@apcraig apcraig requested review from daveh150 and phil-blain July 31, 2022 16:06
@apcraig apcraig mentioned this pull request Jul 31, 2022
Closed
11 tasks
@apcraig
Copy link
Contributor Author

apcraig commented Jul 31, 2022

This was discussed and reviewed in #727, will merge now.

@apcraig apcraig merged commit 063a7f2 into CICE-Consortium:main Jul 31, 2022
@apcraig apcraig mentioned this pull request Aug 1, 2022
Closed
dabail10 pushed a commit to ESCOMP/CICE that referenced this pull request Oct 4, 2022
@apcraig @daveh150 @dabail10
Update cice.t-test.py to use cartopy instead of basemap. (CICE-Consor…
774a1d1 
…tium#742)

* Update cice.t-test.py to use cartopy instead of basemap.

* Bug fix to add gridlines to SH plots

* commented out contour section of plots. Default is pcolor. If contour is selected it will instead make a pcolor plot

* cice.t-test.py: addded individual colorbar to each plot. environment.yml: removed basemap, added cartopy

* Remove shrink option from difference plots

* Add blockall distribution_wght to set_nml.qc to address plotting issues in qc test

Co-authored-by: daveh150 <david.hebert@nrlssc.navy.mil>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveh150 daveh150 Awaiting requested review from daveh150

@phil-blain phil-blain Awaiting requested review from phil-blain

Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @daveh150