Update dEdd implementation #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Icepack with several fixes (changes answers for tr_aero) - Update bgc aerosol table to higher precision - Add modal aerosol tests - Update test suites
|
This is a draft PR, it is waiting for CICE-Consortium/Icepack#400 then I'll update the Icepack revision in this PR. |
There was a problem hiding this comment.
This looks fine to me. @njeffery could you check whether the namelist parameter set in the modified bgcz(m) test (the set_nml.bgczm file) makes sense? And does the set_nml.modal test make sense, or do more things need to be turned on/set?
|
I'm retesting now with the updated Icepack, but confirmed that the new version and the version I was testing are identical. I don't expect any problems. This is ready for review and merge. |
|
Full test suite passes, we should review and merge this. |
eclare108213
approved these changes
Sep 29, 2022
dabail10
pushed a commit
to ESCOMP/CICE
that referenced
this pull request
Oct 4, 2022
* Update dEdd implementation - Update Icepack with several fixes (changes answers for tr_aero) - Update bgc aerosol table to higher precision - Add modal aerosol tests - Update test suites * Update Icepack including dEdd fixes
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update dEdd implementation with fixes
Developer(s):
apcraig, eclare108213
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
bit-for-bit on cheyenne full test suite except alt04, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#007fbff9b1012b4fb1e447141a888d18b6c24d19
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
Update Icepack with several fixes (changes answers for tr_aero)
Update bgc aerosol table to higher precision
Add modal aerosol tests
Update test suites