Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in nmode0 in PIO for CESMCOUPLED #938

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

anton-seaice
Copy link
Contributor

PR checklist

  • Short (1 sentence) summary of your PR:
    There is a typo in the CESMCOUPLED implementation of PIO (updated in Update IO formats and add new IO namelist controls #928)
  • Developer(s):
    @anton-seaice
  • Suggest PR reviewers from list in the column to the right.
    @dabail10
  • Please copy the PR test results link or provide a summary of testing completed below.
    Adhoc testing only. Only impacts CESMCOUPLED.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

For CESMCOUPLED, the pio_iotype is set though CMEPS. For completeness, we also need to check the ioformat set through CMEPS. ioformat is used to set the nmode0. nmode0 and clobber combine to set the nmode flag for pio_createfile / pio_openfile operations. Due a typo nmode0 was not being set for netcdf4 iotypes (before this change).

@anton-seaice
Copy link
Contributor Author

Without the change I get an "Invalid argument" failure:

 ERROR: 
 (abort_ice)(ice_pio_check)NetCDF: Invalid argument, (ice_pio_init) ERROR: Faile
 d to create file ./GMOM_JRA.cice.h.1958-01-04.nc

@apcraig apcraig merged commit 1a530ec into CICE-Consortium:main Feb 28, 2024
2 checks passed
@anton-seaice anton-seaice deleted the cesm_pio_patch branch February 28, 2024 22:01
DeniseWorthen pushed a commit to DeniseWorthen/CICE that referenced this pull request Apr 13, 2024
For CESMCOUPLED, the pio_iotype is set though CMEPS. For completeness, we also need to check the ioformat set through CMEPS. ioformat is used to set the nmode0. nmode0 and clobber combine to set the nmode flag for pio_createfile / pio_openfile operations. Due a typo nmode0 was not being set for netcdf4 iotypes (before this change).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants