add MACHINFO and ENVINFO, remove thunder and loft #323
Conversation
There was a problem hiding this comment.
envname is a little confusing for me, especially since it previously was used for something different. To clarify, it would help to say in more places that it's referring to compilers (but I assume it's more general than that, since you're changing the definition). I've made a couple of recommendations below. Otherwise this is all fine with me.
icepack.setup
Outdated
| @@ -91,7 +91,7 @@ DESCRIPTION | |||
| --docintfc : update the public interface documentation | |||
| --case, -c : case, case directory/name (not with --test or --suite) | |||
| --mach, -m : machine, machine name (required) | |||
| --env, -e : compiler(s), comma separated (default = "intel") | |||
| --env, -e : envname(s), comma separated (default = "intel") | |||
There was a problem hiding this comment.
I wouldn't recognize that envname means compiler, although it helps that you indicate that the default is intel. Maybe 'environment/compiler(s)' ?
There was a problem hiding this comment.
maybe "compilation environment" ?
| @@ -27,7 +27,7 @@ can be modified as needed. | |||
| "ICE_CASENAME", "string", "case name", "set by icepack.setup" | |||
| "ICE_SANDBOX", "string", "sandbox directory", "set by icepack.setup" | |||
| "ICE_MACHINE", "string", "machine name", "set by icepack.setup" | |||
| "ICE_COMPILER", "string", "environment name", "set by icepack.setup" | |||
| "ICE_ENVNAME", "string", "environment name", "set by icepack.setup" | |||
There was a problem hiding this comment.
maybe add clarification here:
environment name (compiler)
|
Good ideas @eclare108213 and @phil-blain. I have updated the documentation. Let me know if that seems better. |
* Fix local solar time * Add line for going past 24 * New LST calculation Addresses #3.
PR checklist
Short (1 sentence) summary of your PR:
add MACHINFO and ENVINFO, remove thunder and loft
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Ran a quick suite on cheyenne on 3 compilers to confirm the new information is available in the results. No code was modified, just scripts. https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#b0b7162f8759f9e0a16dcca6f52a5b9ea268be7d
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Add MACHINFO and ENVINFO to bring in line with recent CICE changes
Rename ICE_COMPILER to ICE_ENVNAME, ICE_MACHINE_COMPILER to ICE_MACHINE_MACHNAME, ICE_MACHINE_COMPILER to ICE_MACHINE_ENVNAME for better consistency with icepack.setup arguments.
rename some icepack.setup variables for better consistency
Remove machines thunder and loft
Fix error in env.conda_macos. it was loading the cice env, changed this to the icepack env which is a subset or the cice env (which is why it was working).
Add -nomodules option to several env files to improve script performance.