zsalinity bug fix

[eclare108213]

• Short (1 sentence) summary of your PR:
  Bug fix: move initialization of the array sicen into the i loop in which it is used.
• Developer(s):
  @eclare108213
• Suggest PR reviewers from list in the column to the right.
• Please copy the PR test results link or provide a summary of testing completed below.

148 measured results of 148 total results
148 of 148 tests PASSED
0 of 148 tests PENDING
0 of 148 tests MISSING data
0 of 148 tests FAILED

https://github.com/CICE-Consortium/Test-Results/wiki/9c33551629.badger.intel.20-12-30.174250.0

• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on CICE or any other models?
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please provide any additional information or relevant details below:

In icedrv_init_column.F90, the sicen array is set as a slice of the trcrn array for each grid cell, but that was done in a loop prior to the loop in which it is used, so only i=nx values were used. The changes to icepack_zbgc.F90 are purely cosmetic.

This does not fix the problem in cice (PR #548). There is another bug fix for that, independent of these changes (PR#549).

[eclare108213]

My base_suite test came back BFB even for the zsal tests. That surprises me, and makes me wonder if there's still another bug in the zsal configuration.

[apcraig]

Travis-ci is currently disable for us. Working on a solution. See CICE-Consortium/CICE#550

[apcraig]

Test results on cheyenne with 4 compilers in CICE using these mods are here, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#dd6e38f84da340b7956dd8a10af04627a1725334

[apcraig]

I will merge this today unless I hear otherwise.

[eclare108213]

go for it, thanks