Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namelist reading #369

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Update namelist reading #369

merged 1 commit into from
Aug 31, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Aug 30, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Update namelist reading to allow arbitrary order of namelist groups. Also fixes nag issue introduced recently and detected on izumi.
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested with 4 compilers on izumi. Passes as expected, fixes issues with izumi+nag. https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#53ffce04d729a3e802b397340c4410126b5b0ac9
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig
update namelist reading to allow arbitrary order of namelist groups. …
3581879 
…Also fixes nag issue introduced recently and detected on izumi
dabail10
dabail10 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for working on this.

@apcraig apcraig merged commit 0836bfc into CICE-Consortium:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10