Pre-release update and minor fixes #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update clone of Test-Results page, add depth=1 - Update documentation of optional arguments - Update interface documentation - Update version
|
@eclare108213, @dabail10 can you review when you get a chance. would like to merge and then get this into cice to continue pre release testing. thanks! |
eclare108213
approved these changes
Aug 4, 2022
|
|
||
| * We recommend doing all checks for optional arguments for an interface before returning just for completeness (as shown above) | ||
|
|
||
| * An argcheck parameter will control when to do the checks, 'none', 'first', or 'all' may be possible settings |
There was a problem hiding this comment.
Is this argcheck parameter implemented anywhere now?
|
For the use statements in snow, I just moved them out of the subroutines to the top of the file, consistent with the rest of Icepack and to make them disappear from the Icepack interface documentation. It's not necessarily an ideal coding standard, but I think it's OK. |
dabail10
reviewed
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Several minor pre-release updates
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Cheyenne suite passes. (https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#dff7810461b7ffd0a91d80fcfa5c7874a3112490)
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Update clone of Test-Results page, add depth=1
Update documentation of optional arguments
Update interface documentation
Update version