Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/san akel/port nccs discover #398

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Feature/san akel/port nccs discover #398

merged 3 commits into from
Aug 17, 2022

Conversation

sanAkel
Copy link
Contributor

@sanAkel sanAkel commented Aug 15, 2022 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Additions to be able to build (and run) on NASA's NCCS discover cluster. Also see following additional information.
  • Developer(s):
    Santha Akella, Matthew Thompson
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213, @apcraig thanks for reviewing. I can't get the labels to work, I guess it should be Porting?
  • Please copy the PR test results link or provide a summary of testing completed below.
    See attached log file icepack.runlog.220815-190420.txt
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
    • N/A; scope of this is completely within configuration/scripts/, no science code has been touched.
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This PR is purely technical: adds the capability to build and run standalone Icepack on another machine, namely NCCS discover cluster which is not currently supported in present release. The additions followed Sec 3.2.2 Porting of Icepack Documentation.

sanAkel added 3 commits August 15, 2022 19:11
@phil-blain
Copy link
Member

small nit, but the title of the PR becomes the title of the commit message once the PR is merged. Thus it would be nice for it to be more explicit, something like:

machines: port to NASA NCCS Discover

or similar.

@apcraig apcraig merged commit e82e3d1 into CICE-Consortium:main Aug 17, 2022
@sanAkel
Copy link
Contributor Author

sanAkel commented Aug 17, 2022

small nit, but the title of the PR becomes the title of the commit message once the PR is merged. Thus it would be nice for it to be more explicit, something like:

machines: port to NASA NCCS Discover

or similar.

Sorry @phil-blain somehow I over looked it. (I did it submit this PR while helping my kid with his homework! ☹️ )

@sanAkel sanAkel deleted the feature/sanAkel/port_NCCS_discover branch August 17, 2022 16:43
@phil-blain
Copy link
Member

No worries, Tony was too eager to click the Merge button :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

@eclare108213 eclare108213 Awaiting requested review from eclare108213

Assignees
No one assigned
Labels
Porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanAkel @phil-blain @apcraig