Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes for snow grain radius, brine conservation check #415

Merged
merged 2 commits into from
Nov 29, 2022
Merged

bug fixes for snow grain radius, brine conservation check #415

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9359a
bug fixes for snow grain radius, brine conservation check
eclare108213 Nov 25, 2022
236023f
bug fix for snow drainage; allow drainage for snow aging when meltpon…
eclare108213 Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions columnphysics/icepack_snow.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ module icepack_snow

real (kind=dbl_kind), parameter, public :: &
S_r = 0.033_dbl_kind, & ! irreducible saturation (Anderson 1976)
S_wet= 4.22e-5_dbl_kind ! (um^3/s) wet metamorphism parameters
S_wet= 4.22e5_dbl_kind ! wet metamorphism parameter (um^3/s)
! = 1.e18 * 4.22e-13 (Oleson 2010)

real (kind=dbl_kind) :: &
min_rhos, & ! snowtable axis data, assumes linear data
Expand Down Expand Up @@ -1079,7 +1080,7 @@ subroutine snow_wet_metamorph (dt, dr_wet, rsnw, smice, smliq)
dr_wet = c0
fliq = c1
if (smice + smliq > c0 .and. rsnw > c0) then
fliq = min(smliq/(smice + smliq),p1)*c100
fliq = min(smliq/(smice + smliq),p1)
dr_wet = S_wet * fliq**3*dt/(c4*pi*rsnw**2)
endif

Expand Down
4 changes: 2 additions & 2 deletions columnphysics/icepack_therm_itd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ subroutine linear_itd (ncat, hin_max, &

if (tr_brine) then
vbrin(n) = vbrin(n) + trcrn(nt_fbri,n) &
* vicen(n)/real(nilyr,kind=dbl_kind)
* vicen(n)
endif

do k = 1, nilyr
Expand Down Expand Up @@ -653,7 +653,7 @@ subroutine linear_itd (ncat, hin_max, &

if (tr_brine) then
vbrin(n) = vbrin(n) + trcrn(nt_fbri,n) &
* vicen(n)/real(nilyr,kind=dbl_kind)
* vicen(n)
endif

do k = 1, nilyr
Expand Down