Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack optional arguments attribute #443

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Update Icepack optional arguments attribute #443

merged 2 commits into from
Jul 18, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 18, 2023

PR checklist

Also cleaned up the intents formatting so it no longer appears on a separate line.

apcraig added 2 commits July 18, 2023 09:09
@apcraig
Update the optional arguments implementation. Found that passing non-…
785eb90 
…scalar optional

arguments down the calling tree without the optional attribute resulted in seg faults
on some machines.  Updated the implementation and documentation to reflect this change.

Cleaned up the rest of the intent lines, so they are not on a new line.
@apcraig
Update documentation
840ef98
@apcraig apcraig requested a review from eclare108213 July 18, 2023 15:19
eclare108213
eclare108213 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@apcraig apcraig merged commit 0ae5792 into CICE-Consortium:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
Documentation Driver/Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213