Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of intermediate groups #122

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Fix creation of intermediate groups #122

merged 3 commits into from
Jan 6, 2022

Conversation

berquist
Copy link
Contributor

@berquist berquist commented Jan 3, 2022

This handles at least part of creating intermediate paths/groups in #36.

dragly
dragly approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@dragly dragly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I reading this correctly: We had the implementation there all along but just did not return the correct value?

Thanks for the contribution!

@dragly dragly merged commit 9bddbf9 into CINPLA:dev Jan 6, 2022
@berquist berquist deleted the return-create-subgroup-recursive branch January 6, 2022 16:00
@berquist berquist mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragly dragly dragly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berquist @dragly