Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak Refining and Doc #70

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Peak Refining and Doc #70

merged 6 commits into from
Sep 6, 2022

Conversation

robinsonianr
Copy link
Collaborator

No description provided.

@bowring
Copy link
Member

bowring commented Sep 1, 2022

getting an error:
java.lang.NumberFormatException: For input string: "Timestamp"
at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
at java.base/jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
at java.base/java.lang.Double.parseDouble(Double.java:651)
at org.cirdles.tripoli.sessions.analysis.massSpectrometerModels.dataSourceProcessors.PeakShapeProcessor_OPPhoenix.prepareInputDataModelFromFile(PeakShapeProcessor_OPPhoenix.java:69)

@bowring
Copy link
Member

bowring commented Sep 1, 2022

good opportunity to write some tests for this

@bowring
Copy link
Member

bowring commented Sep 2, 2022

good progress
note:

  1. on first use of demo2, the auto-selection of the first file does not produce peak shape plots
  2. when plotting ticsY, change line 130 to (float) mapX(minX) - textWidth - 5f,

@robinsonianr
Copy link
Collaborator Author

I believe the auto-selection was not working on the first use because peak service would not complete the task. I changed it not to use the service and it worked.

Copy link
Member

@bowring bowring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@bowring bowring marked this pull request as ready for review September 6, 2022 13:19
@bowring bowring merged commit 289c889 into CIRDLES:main Sep 6, 2022
@robinsonianr robinsonianr deleted the peak-cleanup branch September 7, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants