Fix syntax error #54
Merged
Fix syntax error #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrupeshKumarPatel
pushed a commit
to TrupeshKumarPatel/NGIAB-CloudInfra
that referenced
this pull request
Nov 27, 2023
* Merging pr 45 * merging pr 47 * Adding no-cache option to build * let ngen build steps handle cpp test lib * Update Dockerfile.ngen * Added missing " * Fix syntax error (CIROH-UA#54) * remove $ from build dir in build steps * build wheel for new troute sub package * use build module to build troute-config wheel --------- Co-authored-by: Nels <nfrazier@lynker.com> Co-authored-by: Arpita Patel <gagarp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A syntax error snuck in in #51 when the build type loop was removed. This should fix that (also a good reason why something like #49 and #53 would be extremely helpful in catching these kinds of errors before they propagate into the full CI/CD workflow and pipeline.