Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effie Submission HW2 #19

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

effieyanfei
Copy link

No description provided.

@likangning93
Copy link

Hi Effie, some comments from grading:

I love your animation!

I like your writeup too, but please put it in README.md and rename the existing README.md with the original instructions to INSTRUCTIONS.md. This way, anyone visiting your project on github will see your writeup right away!

I got significantly smoother results for your shadows and normals by setting the EPSILON to 0.01 and setting mint to 0.01 and maxt to 10.0 for the call to "shadow.":

-    float s = shadow(p, LIGHT, 0.0, 1.0, 0.5);
+    float s = shadow(p, LIGHT, 0.01, 10.0, 0.5);

You may also want to normalize the LIGHT
direction that is going in there.

My laptop thanks you for using sphere tracing instead of a fixed stepsize :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants