-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 5: Caroline Lachanski #48
Open
clach
wants to merge
16
commits into
CIS565-Fall-2019:master
Choose a base branch
from
clach:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clach
commented
Oct 30, 2019
- Repo link
- Implemented CPU and GPU sides of DXR raytracing (all required features)
- Used 2 late days (1 remaining)
- Feedback: Though I think this is a cool final project and cool topic in general, I'm not sure it's fully ready to be a GPU homework (no offense to Ziad, I know it was a lot of work to get his project into shape for this). Even as someone very familiar with graphics and raytracing and slightly familiar with DirectX, I still feel like there was so much guess work in filling out the TODOs, especially for the CPU side. It's simply a very big and unfamiliar project, and it's hard to make it feel rewarding if most of our time is spent making (educated) guesses about how to write a specific DXR API call. The project recitation was helpful, but it leaned more towards the conceptual side of things, which was frustrating because I mostly struggled with the DirectX stuff. Can you tell I hate DirectX?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.