Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change include path to match QtC 14 #158

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

zeule
Copy link

@zeule zeule commented Jun 10, 2024

No description provided.

@CJCombrink
Copy link
Owner

Hi @zeule , thanks for the PR

Just to clarify, is this for Qt Creator 14 or 15. I believe 14 is yet to be released, probably not too long from now since it development is in feature freeze.

@@ -20,7 +20,11 @@

#pragma once

#if __has_include(<cppeditor/quickfixes/cppquickfix.h>)
#include <cppeditor/quickfixes/cppquickfix.h>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this due to a header relocation in Qt Creator 14?
At the start of the project I made the call that I will not support past Qt Creator versions, thus if Qt Creator moves the header can you please update the PR to use that header directly, without the additional complexity to work for older versions as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry for the mistake. Indeed, the move occurred in the 14th version. I changed the commit message.

@zeule zeule changed the title Fix build with QtC 15 Change include path to match QtC 14 Jun 11, 2024
@zeule
Copy link
Author

zeule commented Jun 18, 2024

Ping?

@CJCombrink
Copy link
Owner

Ping?

Sorry @zeule I have not had any time test.
I have no problem to merge, normally I just do a build test on my side first but this should be fine.

@CJCombrink CJCombrink merged commit a46a8bb into CJCombrink:main Jun 18, 2024
@zeule
Copy link
Author

zeule commented Jun 18, 2024

Thanks!

@zeule zeule deleted the fix-build branch June 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants