Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Flake8 linting on Github testing action #391

Closed
c-martinez opened this issue Feb 5, 2023 · 2 comments
Closed

Restore Flake8 linting on Github testing action #391

c-martinez opened this issue Feb 5, 2023 · 2 comments

Comments

@c-martinez
Copy link
Collaborator

GitHub testing action used to include Flake8 testing:

    - name: Lint with flake8
      run: |
        # stop the build if there are Python syntax errors or undefined names
        flake8 src/ --count --select=E9,F63,F7,F82 --show-source --statistics
        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
        flake8 src/ --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

I removed it to stop tests from failing and be able to build python for different versions (see #389).

Once that is fixed, we should fix current linting issues and add flake8 testing back in.

@c-martinez
Copy link
Collaborator Author

Addressed by #440

@c-martinez c-martinez mentioned this issue Oct 28, 2023
@c-martinez
Copy link
Collaborator Author

Fixed by #440 -- closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant